fix(examples): consistent CSV schema in survey_agent#1435
Merged
Conversation
Both write paths in writeCsvRow used Object.keys(data) for the row
layout, but only the first call wrote a header — so disqualify rows
(2 cols) and success rows (6 cols) ended up under whichever header
won the race. Pin the schema to a fixed CSV_COLUMNS tuple, write rows
in that order, and fill missing keys as empty.
Also replace the access()+appendFile TOCTOU pattern with a single
open('a') + stat() so the header decision and the write happen on
the same handle, and combine header+row into one appendFile call.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
toubatbrian
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two correctness bugs in
survey_agent.ts: disqualify and success rows used different column sets under one header, andaccess+appendFileraced on header creation.Changes Made
CSV_COLUMNStuple; missing keys become empty cells.access+ twoappendFiles with oneopen('a')+stat()+ singleappendFile.toCsvValue.nameon the success path fromuserData.candidateName.Pre-Review Checklist
Testing
Additional Notes
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.