Attempts to fix build rot #125
Merged
+25
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified the one of the three lines commented out in last commit on requirements.txt caused the build to succeed. Now lint is failing due to missing aiohttp_cors. '
try using aiortc 1.10.1 in requirements.txt but leaving pyproject.toml as it was. I think this will make the CI build for basic_bot pass , but downstream users like portalbot will still fail.
go back to verion that fails local ci, but try and mimmick aiortc ci build here: https://github.com/aiortc/aiortc/blob/main/.github/workflows/tests.yml
go back to verion that fails local ci, but try and mimmick aiortc ci build here: https://github.com/aiortc/aiortc/blob/main/.github/workflows/tests.yml
littlebee
commented
Jan 20, 2026
Owner
Author
littlebee
left a comment
littlebee
left a comment
There was a problem hiding this comment.
todo: create issue: what is the reasoning behind the sorting of dependencies in both pyproject.toml and requirements.txt? Is it possible to alpha sort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build for portalbot is failing.
See also, build fail for portalbot
See commits below for what worked and what didn't. For now, just going to pin to
aiortc==1.10.1.See also aiortc/aiortc#1406.