Skip to content

Conversation

@SharanRP
Copy link

Proposed changes

This PR fixes a bug where the Experiment Run History page would render as a blank page due to a syntax error in a useEffect hook.

The issue was caused by a dependency array being placed outside the useEffect function call in chaoscenter/web/src/controllers/ExperimentRunHistory/ExperimentRunHistory.tsx, leading to a "Minified React error 321" (invalid hook call).

Fixes #5322

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • None

Special notes for your reviewer:

I verified the fix by creating a temporary unit test for the ExperimentRunHistoryController component, which previously failed with the error and now passes. I also manually verified that the page renders correctly.

Screenshot from 2025-11-23 12-24-43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank page when trying to view experiment run history

2 participants