fix(chaoscenter): resolve blank page in experiment run history #5337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a bug where the Experiment Run History page would render as a blank page due to a syntax error in a
useEffecthook.The issue was caused by a dependency array being placed outside the
useEffectfunction call inchaoscenter/web/src/controllers/ExperimentRunHistory/ExperimentRunHistory.tsx, leading to a "Minified React error 321" (invalid hook call).Fixes #5322
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
I verified the fix by creating a temporary unit test for the
ExperimentRunHistoryControllercomponent, which previously failed with the error and now passes. I also manually verified that the page renders correctly.