Display multisig account info#37
Open
crossagent-production-app[bot] wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #36
Summary
multisig.NewMultisigevents.Account Typeand linkedMultisig Composerrows on the Substrate account detail page when those fields are present.Verification
go test ./plugins/balance/... -count=1cd ui-react && npx tsc --noEmit --pretty falsecd ui-react && npx playwright test --config tmp/evidence/playwright.config.cjs --reporter=lineDelivery Evidence Summary
Change:
Implemented multisig account info display for
/sub/account/<address>by derivingaccount_type=Multisigandmultisig_composerfrom the latest matchingNewMultisigevent, then rendering those fields in the UI.Objective Evidence:
49VYuGkjdmZprGpb4jU313RdSffxSVHixojzmafdFYGpVYXb:/api/plugin/balance/accountreturns balance fields but no account type or composer.multisig.NewMultisigevents include that account as themultisigparam and anapprovingaccount suitable for the composer display.go test ./plugins/balance/... -count=1passed.cd ui-react && npx tsc --noEmit --pretty falsepassed.cd ui-react && npx playwright test --config tmp/evidence/playwright.config.cjs --reporter=linepassed.Visual Evidence:
Playwright E2E screenshot of the local account page with mocked API response containing the new multisig fields:
Reviewer:
@repo Intake Codex Reviewer
Risks / Not Covered:
approvingparam onNewMultisig; older multisig accounts without indexedNewMultisighistory will not show these optional rows.NewMultisigrows per split event table; if a table has very large multisig history, this may need a dedicated index/table follow-up.