You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This provides more flexibility into how the files are loaded and could potentially allow loading http-based files or any other type that smart_open supports.
First pass at a PR. Would you be interested in something like this. If so, I'm happy to add tests. If not, I'm also happy to just create a new package.
I'll take a look at this as soon as possible. But some thoughts from a quick overview:
I'd be more inclined to put this behind an optional package dependency, so it can be installed with s3sqlite[smart_open]
It should add the dependency to requirements.txt
I should probably update this repo to use pyproject.toml + uv. But this was mostly an experiment and I haven't looked at this in a while. But we can still get a PR merged and then I'll do the tooling update before pushing a new version.
Also, just to understand better. What would be the use case for using smart_open? i.e: What use-case motivates this change?
I think there's significant overlap between what smart_open and fsspec provide (in terms of capabilities). So just want to review the intended use case, because it may be more optimal to make it fully compatible with any fsspec implementation (instead of just s3fs) instead of adding smart_open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides more flexibility into how the files are loaded and could potentially allow loading http-based files or any other type that smart_open supports.