Open
Conversation
justinfagnani
requested review from
graynorton,
kevinpschaaf and
sorvell
as code owners
43081j
reviewed
Apr 22, 2024
|
|
||
| ## Motivation | ||
|
|
||
| The currently reccomended Lit VS Code extension, lit-plugin, suffers from a few problems: |
There was a problem hiding this comment.
minor misspelling (should be recommended)
|
|
||
| ### Testing Plan | ||
|
|
||
| Since developers will have varying versions of VS Code of TypeScript, we will need to test against multiple versions of TypeScript. Setting this up is a bit complicated, but we have experience from lit-plugin on how to do this. |
There was a problem hiding this comment.
maybe its worth mentioning we may want to also have a test suite run by vscode itself (using vscode-test)
e111077
reviewed
Apr 24, 2024
|
|
||
| ## Downsides | ||
|
|
||
| This is a lot of work to create and maintain. |
There was a problem hiding this comment.
Might be worth lightly scoping out what parts of the project would be difficult to maintain
|
|
||
| ### Documentation Plan | ||
|
|
||
| We will need documentation in the lit.dev tooling section. |
There was a problem hiding this comment.
What would this look like? Document only on installing it and its features or do we need to go deeper on how it works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.