Skip to content

Show Error If State Name Is Uppercase #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 1 commit into from
Sep 28, 2025
Merged

Show Error If State Name Is Uppercase #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions liquidjava-verifier/src/main/java/liquidjava/errors/ErrorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ public static void printCostumeError(CtElement element, String msg, ErrorEmitter
sb.append(element + "\n\n");
sb.append("Location: " + element.getPosition() + "\n");
sb.append("______________________________________________________\n");
sb.append(sb.toString());
Copy link
Collaborator Author

@rcosta358 rcosta358 Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was duplicating the same error in the output



errorl.addError(s, sb.toString(), element.getPosition(), 1);
}

Expand Down
13 changes: 13 additions & 0 deletions liquidjava-verifier/src/main/java/liquidjava/processor/refinement_checker/TypeChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,19 @@ public void handleStateSetsFromAnnotation(CtElement element) {
}

private void createStateSet(CtNewArray<String> e, int set, CtElement element) {

// if any of the states starts with uppercase, throw error (reserved for alias)
for (CtExpression<?> ce : e.getElements()) {
if (ce instanceof CtLiteral<?>) {
@SuppressWarnings("unchecked")
CtLiteral<String> s = (CtLiteral<String>) ce;
String f = s.getValue();
if (Character.isUpperCase(f.charAt(0))) {
ErrorHandler.printCostumeError(s, "State name must start with lowercase in '" + f + "'", errorEmitter);
}
}
}

Optional<GhostFunction> og = createStateGhost(set, element);
if (!og.isPresent()) {
throw new RuntimeException("Error in creation of GhostFunction");
Expand Down