Qualify Ghost Names #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added qualified names so ghosts/states with the same name from different classes don't conflict with each other.
Motivation
Different classes frequently reuse ghost/state names (e.g.,
open,close,size). Without qualification, simple name lookups collide, causing wrong substitutions and sort mismatches in the SMT solver.Key Changes
java.util.ArrayList.size,com.example.SM1.initialized).old,length,addToIndexandgetFromIndex.VCCheckerfilters candidate ghosts/states to those whose prefix matches the types (and supertypes) of variables in the current VC, preventing unrelated classes with the same simple name from matching (removes ambiguity).AuxStateHandlerso subclasses can reference superclass states (Bus.close->Car.close)TranslatorToZ3to match by simple name and number of parameters, preferring exact qualified names.