Conversation
CatarinaGamboa
approved these changes
May 5, 2026
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
ok this looks good
| | pred BOOLOP pred #expBool | ||
| | pred '&&' pred #predLogic | ||
| | pred '||' pred #predLogic | ||
| | <assoc=right> pred '-->' pred #predLogic |
Collaborator
There was a problem hiding this comment.
ok didnt know you could use <assoc=right>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes operator precedence in the LiquidJava refinements, where e.g. the operators
+and-had the same precedence as*,/, and%. This could lead to unexpected bugs and forced users to explicitly group expressions in parentheses.Also, the grammar rejected some valid nested boolean expressions, such as
"_ == (true || false && false)", because&&and||were not allowed in theexprule.Finally, the parser could accept only a valid prefix of the expression. For example, the refinement
true falsewould be accepted astrueinstead of throwing a syntax error, silently ignoringfalse.Changes
The grammar now defines expression parsing in a single left-recursive
predrule, making the precedence order explicit, with the last two being right associative:!→* / %→+ -→== != >= > <= <→&&→||→-->→? :To make sure the whole refinement string is consumed,
prog: start | ;was changed to toprog: start EOF;andparser.start()toparser.prog().Examples