Skip to content

Fix getNextId to support variable-width numeric IDs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linyows merged 1 commit into from
Feb 6, 2026
Merged

Fix getNextId to support variable-width numeric IDs #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 115 additions & 8 deletions src/utils.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pub fn getNextId(allocator: mem.Allocator, cwd: fs.Dir, output_dir: []const u8)

var dir = cwd.openDir(output_dir, .{ .iterate = true }) catch |err| {
if (err == error.FileNotFound) {
return try std.fmt.allocPrint(allocator, "{d:0>3}", .{1});
return try std.fmt.allocPrint(allocator, "{d}", .{1});
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function now returns unpadded ID strings (e.g., '1' instead of '001'), which may break existing code that expects zero-padded IDs. Consider whether the calling code handles formatting separately, or if padding width should be determined from existing files in the directory.

Copilot uses AI. Check for mistakes.
}
return err;
};
Expand All @@ -44,16 +44,21 @@ pub fn getNextId(allocator: mem.Allocator, cwd: fs.Dir, output_dir: []const u8)
if (entry.kind != .file) continue;
if (!mem.endsWith(u8, entry.name, ".md")) continue;

if (entry.name.len >= 3) {
const id_part = entry.name[0..3];
const id = std.fmt.parseInt(u32, id_part, 10) catch continue;
if (id > max_id) {
max_id = id;
}
// Extract leading digits from filename
var digit_end: usize = 0;
while (digit_end < entry.name.len and entry.name[digit_end] >= '0' and entry.name[digit_end] <= '9') {
digit_end += 1;
}
if (digit_end == 0) continue;

const id_part = entry.name[0..digit_end];
const id = std.fmt.parseInt(u32, id_part, 10) catch continue;
if (id > max_id) {
max_id = id;
}
}

return try std.fmt.allocPrint(allocator, "{d:0>3}", .{max_id + 1});
return try std.fmt.allocPrint(allocator, "{d}", .{max_id + 1});
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function now returns unpadded ID strings, which differs from the previous zero-padded format. This may break existing code that expects zero-padded IDs. Consider whether the calling code handles formatting separately, or if padding width should be determined from existing files in the directory.

Copilot uses AI. Check for mistakes.
}

// =============================================================================
Expand Down Expand Up @@ -89,3 +94,105 @@ test "getUsername: returns non-empty string" {

try testing.expect(username.len > 0);
}

test "getNextId: returns 1 when directory not found" {
const allocator = testing.allocator;
var tmp = testing.tmpDir(.{});
defer tmp.cleanup();

const next_id = try getNextId(allocator, tmp.dir, "nonexistent");
defer allocator.free(next_id);

try testing.expectEqualStrings("1", next_id);
}

test "getNextId: returns 1 when directory is empty" {
const allocator = testing.allocator;
var tmp = testing.tmpDir(.{});
defer tmp.cleanup();

try tmp.dir.makeDir("docs");

const next_id = try getNextId(allocator, tmp.dir, "docs");
defer allocator.free(next_id);

try testing.expectEqualStrings("1", next_id);
}

test "getNextId: returns next id with 3-digit filenames" {
const allocator = testing.allocator;
var tmp = testing.tmpDir(.{});
defer tmp.cleanup();

try tmp.dir.makeDir("docs");
var docs = try tmp.dir.openDir("docs", .{});
defer docs.close();

// Create 001-foo.md, 002-bar.md
{
const f = try docs.createFile("001-foo.md", .{});
f.close();
}
{
const f = try docs.createFile("002-bar.md", .{});
f.close();
}

const next_id = try getNextId(allocator, tmp.dir, "docs");
defer allocator.free(next_id);

try testing.expectEqualStrings("3", next_id);
}

test "getNextId: returns next id with 4-digit filenames" {
const allocator = testing.allocator;
var tmp = testing.tmpDir(.{});
defer tmp.cleanup();

try tmp.dir.makeDir("docs");
var docs = try tmp.dir.openDir("docs", .{});
defer docs.close();

// Create 0001-foo.md, 0002-bar.md
{
const f = try docs.createFile("0001-foo.md", .{});
f.close();
}
{
const f = try docs.createFile("0002-bar.md", .{});
f.close();
}

const next_id = try getNextId(allocator, tmp.dir, "docs");
defer allocator.free(next_id);

try testing.expectEqualStrings("3", next_id);
}

test "getNextId: skips non-numeric filenames" {
const allocator = testing.allocator;
var tmp = testing.tmpDir(.{});
defer tmp.cleanup();

try tmp.dir.makeDir("docs");
var docs = try tmp.dir.openDir("docs", .{});
defer docs.close();

{
const f = try docs.createFile("0001-foo.md", .{});
f.close();
}
{
const f = try docs.createFile("README.md", .{});
f.close();
}
{
const f = try docs.createFile("notes.md", .{});
f.close();
}

const next_id = try getNextId(allocator, tmp.dir, "docs");
defer allocator.free(next_id);

try testing.expectEqualStrings("2", next_id);
}