Skip to content

Update default.conf.sample to deny dotfile access#26

Open
nemchik wants to merge 2 commits intomainfrom
deny-dotfile-access
Open

Update default.conf.sample to deny dotfile access#26
nemchik wants to merge 2 commits intomainfrom
deny-dotfile-access

Conversation

@nemchik
Copy link
Copy Markdown
Member

@nemchik nemchik commented Feb 8, 2026

No description provided.

Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-your_spotify:1.17.0-pkg-a99219ae-dev-571a87d98edc590dbf4f2f267148bc5549a09953-pr-26

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-your_spotify:1.18.0-pkg-28e95734-dev-f283283fa9cf581e766d78b63824374c0dd87c14-pr-26

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Signed-off-by: Eric Nemchik <eric@nemchik.com>
Copilot AI review requested due to automatic review settings May 5, 2026 21:45
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the sample nginx site configuration for the your_spotify container to block access to dotfiles while preserving access to /.well-known, and records that change in the image changelog.

Changes:

  • Added a generic nginx rule intended to deny access to dotfiles in the sample site config.
  • Added an exception for /.well-known requests in the sample site config.
  • Added a changelog entry in readme-vars.yml telling existing users to update their nginx config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
root/defaults/nginx/site-confs/default.conf.sample Adds the new dotfile-deny rule and the /.well-known exception in the sample nginx vhost.
readme-vars.yml Adds the corresponding changelog note for existing users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

index index.html;

# Allow access to the ".well-known" directory
location ^~ /.well-known {
Comment on lines +18 to +19
# Allow access to the ".well-known" directory
location ^~ /.well-known {
@LinuxServer-CI LinuxServer-CI moved this from PRs Ready For Team Review to PRs in Issue & PR Tracker May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants