Check for existing Mint GRUB snippet before using default GRUB#6
Open
ddimitrovv wants to merge 1 commit intolinuxmint:masterfrom
Open
Conversation
This ensures that mintsysadm reads the Mint-specific GRUB configuration first (/etc/default/grub.d/98_mintsysadm.cfg), falling back to the default GRUB file only if the snippet does not exist. Improves consistency with actual system settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the Boot Menu page correctly reflects existing GRUB settings
by preferring the Mint‑managed snippet
/etc/default/grub.d/98_mintsysadm.cfgand only falling back to
/etc/default/grubwhen the snippet doesn’t exist.Motivation
On systems upgraded from older Mint releases, the default
/etc/default/grubfile contains valid GRUB settings, but the tool did not display them
because it only looked for the Mint snippet. This change improves UX
by making the Boot menu page reflect actual GRUB configuration.
Implementation
get_existing_grub_path()helper to choose the correct file.get_boot_config()to use this choice.