Skip to content

Fixes in "printers@cinnamon.org"#13524

Open
hans-fritz-pommes wants to merge 3 commits intolinuxmint:masterfrom
hans-fritz-pommes:patch-1
Open

Fixes in "printers@cinnamon.org"#13524
hans-fritz-pommes wants to merge 3 commits intolinuxmint:masterfrom
hans-fritz-pommes:patch-1

Conversation

@hans-fritz-pommes
Copy link

@hans-fritz-pommes hans-fritz-pommes commented Feb 1, 2026

I encountered several small issues with the printers applet.
I modified the applet.js in /usr/share/cinnamon/applets/printers@cinnamon.org and tested printing documents.
The things I did correct:

  • The "Cancel all jobs" command didn't work for an user who had no permisisons to run cancel -a for a specific printer, even if all of the jobs on this printer belonged to him.
    -> Now the "Cancel all jobs" command tries to cancel every single job, not cancel -a for every printer
  • The appearance of the listed jobs was really bad: e.g. when you had more than one job, the description for every job was "<desc. first job><desc. second job><desc..." and so on.
  • The job description consisted of: (job number) lpstat -o (lpstat several times, if there was more than one job - see point before)
    -> The description is now: (job number) 'document_name' on <printer_name> (<size in Bytes/MB/KB>) by <user> (using lpq -a).

The following problem could occur:
If a job has the same number as byte-size like the job-id of the following one, the username and the filesize of the first one will be strange (job-id and functions stay working).
I would say this will happen that seldom - we should ignore it.
Which user will open the menu exactly in that minute and have a problem with a strange username or filesize?

EDIT: fixed in new commit

@hans-fritz-pommes
Copy link
Author

Oh and I changed icons. If you think they're ugly, just revert it

@hans-fritz-pommes hans-fritz-pommes marked this pull request as draft February 1, 2026 19:18
@hans-fritz-pommes
Copy link
Author

I have an idea how to fix this mini-problem (identical bytes & job-number). But later

Fix mini-problem (See linuxmint#13524)
@hans-fritz-pommes hans-fritz-pommes marked this pull request as ready for review February 1, 2026 20:54
@hans-fritz-pommes
Copy link
Author

Ok, now the identical bytes/document-name & job-number-problem is fixed.

@hans-fritz-pommes hans-fritz-pommes marked this pull request as draft February 2, 2026 12:36
@hans-fritz-pommes
Copy link
Author

Sorry that I'm so chaotic
I forgot to take care of document names with whitespaces

Support filenames with whitespaces
@hans-fritz-pommes hans-fritz-pommes marked this pull request as ready for review February 2, 2026 14:11
@claudiux claudiux requested a review from clefebvre February 2, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant