Make notifications applet multi instance #13025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2025
fredcw
force-pushed
the
notificationMulti
branch
2 times, most recently
from
6d2f3cc to
51ce923
Compare
fredcw
force-pushed
the
notificationMulti
branch
2 times, most recently
from
40274f3 to
2c19c41
Compare
Member
|
Please rebase this one. |
fredcw
force-pushed
the
notificationMulti
branch
from
2c19c41 to
9fbe6e9
Compare
Contributor
Author
|
@clefebvre rebase done. |
and do not recreate menu on orientation change. Disconnect signals on applet close. Cleanup code a little bit
fredcw
force-pushed
the
notificationMulti
branch
from
9fbe6e9 to
da98738
Compare
Contributor
Author
|
Ah, I fixed the merge conflict but in the wrong commit, so I've just squashed the two commits together. All good now. |
Contributor
Author
|
@clefebvre I've created two new PRs to replace this one if you prefer. Since this PR does two different things, I thought it might be better for the commit history to separate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #12569
Edit: I guess it makes sense to merge these two commits separately as they do different things.