Skip to content

directory-menu@torchipeppo: Add native version with Wayland support#8255

Merged
rcalixte merged 16 commits intolinuxmint:masterfrom
anaximeno:directory-menu-add-native-version
Feb 8, 2026
Merged

directory-menu@torchipeppo: Add native version with Wayland support#8255
rcalixte merged 16 commits intolinuxmint:masterfrom
anaximeno:directory-menu-add-native-version

Conversation

@anaximeno
Copy link
Copy Markdown
Contributor

This adds a Native to Cinnamon version of the applet with the main goal of allowing Wayland support for the applet. In X11 sessions this native implementation is accessible and usable as well (the user must change to it in settings), but the default remains the previous Gtk based implementation now labeled as "classic". For Wayland sessions the native version is set to run instead, but this behavior can also be disabled from the settings.

ref: torchipeppo/directory-menu-for-cinnamon#2 (I've discussed this with the author in their personal repo before sending this PR)

I'll also ping @torchipeppo here for their review.

Video example of how it should work

2026-01-30.03-51-36.mp4

@torchipeppo
Copy link
Copy Markdown
Contributor

torchipeppo commented Jan 30, 2026

Hi, thank you very much for your work.
I tried a quick test-spice on my Mint 21.3 machine to confirm the GTK behavior remains the same, and it does, but it looks like I can't open the settings.
It may still be something dumb on my end. I'll be looking into it some other time.

Apart from that, it's all great! I appreciate the fix to quit unmapped menu processes too, I hadn't noticed that in my earlier pass.

@rcalixte
Copy link
Copy Markdown
Member

but it looks like I can't open the settings

Sometimes things can get wedged and require a Cinnamon restart. If that doesn't work, do you want to hold off on merging this?

@anaximeno
Copy link
Copy Markdown
Contributor Author

anaximeno commented Jan 30, 2026

Apart from that, it's all great! I appreciate the fix to quit unmapped menu processes too, I hadn't noticed that in my earlier pass.

I also commented a line regarding the event.free() I noticed it came from the xapps c code, but shouldn't be required on Python since it handles the free automatically with the garbage collector, and I think this might've been the reason I've been having for some time seeing stack traces about a python process from the applet popup_menu.py script appearing in the reports app.

image

It didn't happen anymore after that (I can send these fixes on a different PR if this is holded for now).

@anaximeno
Copy link
Copy Markdown
Contributor Author

anaximeno commented Jan 30, 2026

Regarding the settings not opening issue, consider checking the logs with either the Cinnamon Looking Glass app or reading the ~/.xsession-errors file, if you find something relevant, alert me and I'll fix it.

@torchipeppo
Copy link
Copy Markdown
Contributor

Hi, sorry for the delay.

I can't see any logs despite multiple Cinnamon restarts, but it seems like the issue only affects the test-spice version. Applying your changes to my development copy of the applet results in everything working correctly, including the settings.

Actually, even the test-spice of the current version of the applet doesn't show the settings either, so this is probably a glitch contained within devtest.

So, I'm optimistic that the merge will be okay. Let's go with it and see if anything happens.

@rcalixte rcalixte merged commit 21936ea into linuxmint:master Feb 8, 2026
1 check passed
@anaximeno anaximeno deleted the directory-menu-add-native-version branch February 8, 2026 18:01
@torchipeppo
Copy link
Copy Markdown
Contributor

torchipeppo commented Feb 8, 2026

Downloaded the update, can confirm everything is in order. Thanks a lot to @anaximeno for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants