Conversation
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the DynamoDB backfill script where condition expressions referenced attribute names that weren't part of the update operation, causing validation errors during actual AWS updates that weren't detected in dry-run mode.
Key Changes:
- Introduced dynamic condition expression building based on fields being updated
- Changed attribute name maps from pre-populated to conditionally populated
- Added new
buildConditionExpressionfunction to generate condition expressions that only reference attribute names actually being set
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
cc @mlehotskylf @ahmedomosanya - fix the issue with actual AWS update that wasn't detected in dry-run mode. No logic updates.
Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot