Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: store multiple repo licenses as array IN-1099 #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: store multiple repo licenses as array IN-1099 #4105
Changes from all commits
59d3902c471e3bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confidence map may never populate due to field access
Medium Severity
The code accesses
(mf.get("matched_license") or {}).get("spdx_id")assumingmatched_licenseis a dict. If the licensee gem serializesmatched_licenseas a plain string (the SPDX ID directly, e.g."MIT"), theor {}fallback won't trigger (since a non-empty string is truthy), and calling.get("spdx_id")on a string raisesAttributeError. This would be caught by the outerexcept Exceptionon line 83, causing the function to always return[]— silently disabling license detection for all repositories. Even ifmatched_licenseis correctly a dict, theconfidence_by_spdxmap remains empty if the key differs betweenmatched_filesandlicensesentries, causing all licenses to bypass confidence filtering.Reviewed by Cursor Bugbot for commit c471e3b. Configure here.
Uh oh!
There was an error while loading. Please reload this page.