Skip to content

fix(cli): validate migration name and correctly report created migration files #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Muawiya-contact wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −8
Open

fix(cli): validate migration name and correctly report created migration files #4103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions scripts/cli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,23 +293,33 @@ function build() {
}

function create_migration() {
MIG_NAME="$1"
MIG_NAME="$(printf '%s\n' "$1" | tr -s ' ' | xargs)"
if [[ -z "$MIG_NAME" ]] || [[ ! "$MIG_NAME" =~ ^[A-Za-z0-9_-]+$ ]]; then
error "Migration name must be non-empty and contain only letters, numbers, underscores, or hyphens"
exit 1
Comment on lines +296 to +299
fi

MIG_VERSION=$(date +%s)
UP_MIG_FILE="${CLI_HOME}/../backend/src/database/migrations/V${MIG_VERSION}__${MIG_NAME}.sql"
DOWN_MIG_FILE="${CLI_HOME}/../backend/src/database/migrations/U${MIG_VERSION}__${MIG_NAME}.sql"
touch $UP_MIG_FILE
touch $DOWN_MIG_FILE
yell "Created ${MIG_FILE}"
touch "$UP_MIG_FILE"
touch "$DOWN_MIG_FILE"
yell "Created $UP_MIG_FILE and $DOWN_MIG_FILE"
}

function create_product_migration() {
MIG_NAME="$1"
MIG_NAME="$(printf '%s\n' "$1" | tr -s ' ' | xargs)"
if [[ -z "$MIG_NAME" ]] || [[ ! "$MIG_NAME" =~ ^[A-Za-z0-9_-]+$ ]]; then
error "Migration name must be non-empty and contain only letters, numbers, underscores, or hyphens"
exit 1
Comment on lines +311 to +314
fi

MIG_VERSION=$(date +%s)
UP_MIG_FILE="${CLI_HOME}/../backend/src/product/migrations/V${MIG_VERSION}__${MIG_NAME}.sql"
DOWN_MIG_FILE="${CLI_HOME}/../backend/src/product/migrations/U${MIG_VERSION}__${MIG_NAME}.sql"
touch $UP_MIG_FILE
touch $DOWN_MIG_FILE
yell "Created ${MIG_FILE}"
touch "$UP_MIG_FILE"
touch "$DOWN_MIG_FILE"
yell "Created $UP_MIG_FILE and $DOWN_MIG_FILE"
}

function build_and_publish() {
Expand Down
Loading