fix: set "compress_to_zip" compress level to 0

[LiHua000]

Log: as title

Summary by Sourcery

Bug Fixes:

• Correct the default compression level for "compress to zip" startup mode to use level 0 instead of 1.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiHua000

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the default compression level for the 'compress to zip/7z' startup path so that ZIP archives are created with compression level 0 instead of 1 when finishing size calculation.

Class diagram for updated compression level behavior in MainWindow

classDiagram
    class MainWindow {
        - StartupType m_eStartupType
        - CompressSettingPage m_pCompressSettingPage
        + slotFinishCalculateSize(size qint64, strArchiveFullPath QString, listAddEntry QList_FileEntry, stOptions CompressOptions, listAllEntry QList_FileEntry) void
    }

    class CompressOptions {
        int iCompressionLevel
        ...
    }

    class StartupType {
        <<enumeration>>
        ST_Compresstozip7z
        ...
    }

    class CompressSettingPage {
        + isOrderMode() bool
        ...
    }

    MainWindow --> CompressOptions : uses
    MainWindow --> StartupType : reads
    MainWindow --> CompressSettingPage : uses

Loading

File-Level Changes

Change	Details	Files
Set the compression level used for 'compress to zip/7z' operations to 0 instead of 1 when finishing the size calculation.	Update the compression options structure to assign compression level 0 before proceeding with compression when the startup type is 'ST_Compresstozip7z'	src/source/mainwindow.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider replacing the magic numbers for iCompressionLevel (e.g., 0, 1) with named constants or an enum to make the intended behavior and semantics of each level clearer.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider replacing the magic numbers for `iCompressionLevel` (e.g., `0`, `1`) with named constants or an enum to make the intended behavior and semantics of each level clearer.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[LiHua000]

/merge

[deepin-ci-robot]

deepin pr auto review

这段代码的修改将压缩级别从 1 改为了 0，这是一个需要谨慎评估的改动。以下是对此代码修改的详细审查意见，涵盖逻辑、质量、性能和安全四个方面：

1. 语法与逻辑审查

• 语法正确性：代码本身语法正确，能够正常编译和运行。
• 逻辑分析：
  • 修改意图：将压缩级别 iCompressionLevel 从 1 修改为 0。在大多数压缩库（如 7z, zip）中，0 通常代表“仅存储”模式，即不进行实际的数据压缩，只打包文件；而 1 通常代表“最快”压缩模式，会进行少量的压缩。
  • 潜在问题：这段代码位于 slotFinishCalculateSize（计算大小完成）槽函数中，且仅在 ST_Compresstozip7z（压缩为 zip 或 7z）启动类型下生效。如果这里的目的是为了快速生成预览或仅打包而不压缩以节省时间，那么逻辑上是通的。但如果用户期望的是压缩文件，这将导致生成的文件体积非常大，违背了压缩软件的基本功能预期。
  • 上下文影响：修改后的代码紧接着是一个 #ifdef 块，判断是否为排序模式。如果排序模式需要特定的压缩设置，强制将压缩级别设为 0 可能会覆盖用户在界面上的设置，或者与排序模式的预期行为冲突。

2. 代码质量审查

• 魔法数字：直接使用 0 和 1 作为压缩级别是典型的“魔法数字”问题。这降低了代码的可读性和可维护性。
  • 改进建议：建议定义枚举或常量来明确压缩级别的含义。例如：

    enum CompressionLevel {
        CL_STORE_ONLY = 0, // 仅存储
        CL_FASTEST = 1,    // 最快速度
        // ...
    };
    // 使用时
    stOptions.iCompressionLevel = CompressionLevel::CL_STORE_ONLY;

• 参数传递方式：stOptions 是按值传递的。这意味着在函数内部修改它，不会影响函数外部的原始对象（除非这个对象在函数末尾被用来执行实际操作并传回，或者后续逻辑依赖这个局部副本）。如果目的是修改后续流程中使用的配置，请确保这个局部 stOptions 确实被传递给了后续的压缩执行函数。

3. 代码性能审查

• 正面影响：将压缩级别设为 0（仅存储）将显著提高压缩速度，因为跳过了耗时的 CPU 密集型压缩算法计算。
• 负面影响：生成的文件体积将几乎等于所有原始文件的总和，导致磁盘 I/O 和存储空间的压力增大。如果用户是在网络传输该文件，带宽消耗也会增加。

4. 代码安全审查

• 安全性：此修改本身不引入直接的内存安全漏洞（如缓冲区溢出）或注入漏洞。
• 资源耗尽风险：虽然不是传统意义上的安全漏洞，但如果用户误操作或程序逻辑错误导致在处理大文件时默认使用 0 级别，可能会迅速填满磁盘空间，导致拒绝服务（DoS）。

总结与改进建议

结论：除非有非常明确的业务需求（例如：用户明确选择了“极速模式”且该模式定义为“仅打包不压缩”，或者这是一个内部测试用的临时修改），否则不建议将默认压缩级别强制改为 0。这会严重影响用户体验（文件体积过大）。

改进建议：

1. 明确业务逻辑：确认为什么在计算完大小后需要强制修改压缩级别。如果是为了优化“快速压缩”场景，应该由用户配置决定，而不是在代码底层强制写死。
2. 消除魔法数字：使用枚举或命名常量代替 0 和 1。
3. 检查参数生命周期：确认 stOptions 是局部副本还是引用，确保修改能够生效且符合预期。
4. 代码格式：#ifdef 前缺少缩进和对应的 #endif（虽然 diff 可能未显示完整），建议检查代码块的完整性，保持良好的缩进。

修改后的代码示例（如果必须保留该逻辑）：

// 假设在头文件中定义了常量
// const int COMPRESSION_LEVEL_STORE = 0;

void MainWindow::slotFinishCalculateSize(qint64 size, QString strArchiveFullPath, QList<FileEntry> listAddEntry, CompressOptions stOptions, QList<FileEntry> listAllEntry)
{
    if (StartupType::ST_Compresstozip7z == m_eStartupType) {
        // 使用命名常量，并添加注释解释原因
        // 针对特定启动类型，强制使用存储模式以提升处理速度
        stOptions.iCompressionLevel = COMPRESSION_LEVEL_STORE; 
        
#ifdef DTKCORE_CLASS_DConfigFile
        if (m_pCompressSettingPage->isOrderMode()) {
            // ...
        }
#endif
    }
    // ... 后续逻辑
}