-
Notifications
You must be signed in to change notification settings - Fork 37
build(debian): separate Qt5/Qt6 build configurations for V25/V20 support #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces a separate Debian packaging control file with Qt5-based build dependencies and runtime dependencies for the deepin-compressor package, laying groundwork to distinguish Qt5/Qt6 build configurations for different V25/V20 targets. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The dependency qualifiers
unar[i386 amd64]andunrar[i386 amd64]are missing the required space before the architecture list and should be written asunar [i386 amd64]andunrar [i386 amd64]to be valid Debian control syntax. - Introducing
debian/control.1alongsidedebian/controlis unusual in Debian packaging; consider clarifying or adjusting how this alternative control file is selected/used so tools likedpkg-buildpackageandsbuildconsistently pick the intended configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The dependency qualifiers `unar[i386 amd64]` and `unrar[i386 amd64]` are missing the required space before the architecture list and should be written as `unar [i386 amd64]` and `unrar [i386 amd64]` to be valid Debian control syntax.
- Introducing `debian/control.1` alongside `debian/control` is unusual in Debian packaging; consider clarifying or adjusting how this alternative control file is selected/used so tools like `dpkg-buildpackage` and `sbuild` consistently pick the intended configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review这段 以下是对该变更的审查意见,涵盖语法逻辑、代码质量、代码性能和代码安全四个方面: 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与改进建议
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Log: as title
Summary by Sourcery
Build: