build(debian): separate Qt5/Qt6 build configurations for V25/V20 support#445
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Jan 29, 2026
Merged
build(debian): separate Qt5/Qt6 build configurations for V25/V20 support#445deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's GuideAdds an alternative Debian control file (control.1) defining a Qt5-based build configuration for deepin-camera, likely to support V20 alongside an existing Qt6-based configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review这份 以下是对该变更的详细审查意见，分为语法逻辑、代码质量、代码性能（此处主要指包管理效率）和代码安全四个方面。 1. 语法逻辑审查
2. 代码质量审查
3. 代码性能（包管理效率）审查
4. 代码安全审查
总结与改进建议
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The new
debian/control.1file appears to largely duplicatedebian/control; consider clarifying the intent (e.g., version-specific naming or using a single control file with conditionals) to avoid configuration drift between the two. - The
Depends:line indebian/control.1is very long and hard to maintain; splitting it across multiple lines with standard Debian continuation formatting would improve readability and reduce the chance of merge errors. - In
debian/control.1, theDescription:field formatting is slightly off (missing a space afterDescription:and double space infor UOS); aligning it with standard Debian control file formatting will help tooling and consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `debian/control.1` file appears to largely duplicate `debian/control`; consider clarifying the intent (e.g., version-specific naming or using a single control file with conditionals) to avoid configuration drift between the two.
- The `Depends:` line in `debian/control.1` is very long and hard to maintain; splitting it across multiple lines with standard Debian continuation formatting would improve readability and reduce the chance of merge errors.
- In `debian/control.1`, the `Description:` field formatting is slightly off (missing a space after `Description:` and double space in `for UOS`); aligning it with standard Debian control file formatting will help tooling and consistency.
## Individual Comments
### Comment 1
<location> `debian/control.1:50-51` </location>
<code_context>
+ ${misc:Depends},
+ libavcodec58 (>= 7:4.0) | libavcodec60, libavformat58 (>= 7:4.1) | libavformat60, libavutil56 (>= 7:4.0) | libavutil58, libswresample3 (>= 7:4.0) | libswresample4, libswscale5 (>= 7:4.0) | libswscale7, libffmpegthumbnailer4v5, libgl1, libpng16-16 (>= 1.6.2-1), libportaudio2 (>= 19+svn20101113), libgstreamer-plugins-base1.0-0 (>= 1.0.0), libgstreamer1.0-0 (>= 1.4.0)
+Recommends: libimageeditor6 | libimageeditor, uos-reporter, deepin-event-log
+Description:this package software for UOS
+ deepin-camera is a tool to view camera, and also a smart take photo and video in life.
</code_context>
<issue_to_address>
**issue:** Tighten and fix the Description fields to follow Debian policy and improve clarity.
The short description should be a concise noun phrase and must include a space after `Description:`. The current text (`"this package software for UOS"`) is ungrammatical and has a double space before `UOS`. For example:
```text
Description: camera and video capture tool for UOS
deepin-camera is a tool to view camera output and to take photos and videos.
```
</issue_to_address>
### Comment 2
<location> `debian/control.1:41` </location>
<code_context>
+ qt6-tools-dev-tools,
+ qt6-svg-dev
Standards-Version: 4.1.2
Homepage: http://www.deepin.org
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Consider using HTTPS for the Homepage field.
If the site supports it, updating this to `https://www.deepin.org` will prevent mixed-content/tooling warnings and align with current security best practices.
```suggestion
Homepage: https://www.deepin.org
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+50
to
+51
| Description:this package software for UOS | ||
| deepin-camera is a tool to view camera, and also a smart take photo and video in life. |
There was a problem hiding this comment.
issue: Tighten and fix the Description fields to follow Debian policy and improve clarity.
The short description should be a concise noun phrase and must include a space after Description:. The current text ("this package software for UOS") is ungrammatical and has a double space before UOS. For example:
Description: camera and video capture tool for UOS
deepin-camera is a tool to view camera output and to take photos and videos.
| qttools5-dev-tools, | ||
| libqt5svg5-dev | ||
| Standards-Version: 4.1.2 | ||
| Homepage: http://www.deepin.org |
There was a problem hiding this comment.
🚨 suggestion (security): Consider using HTTPS for the Homepage field.
If the site supports it, updating this to https://www.deepin.org will prevent mixed-content/tooling warnings and align with current security best practices.
Suggested change
| Homepage: http://www.deepin.org | |
| Homepage: https://www.deepin.org |
lzwind
approved these changes
Jan 29, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
Contributor
|
This pr cannot be merged! (status: unstable) |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: as title
Summary by Sourcery
Build: