Revert "deps: migrate from p7zip-full to 7zip package"#113
Revert "deps: migrate from p7zip-full to 7zip package"#113wangrong1069 wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
This reverts commit 4764b67.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts the dependency change from the 7zip package back to p7zip in the RPM spec to restore the previous packaging requirement, aligning runtime dependencies with earlier behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If the intent is to fully revert the migration to 7zip, double‑check that all packaging targets (including the debian/control file and any build scripts) consistently depend on p7zip and no references to 7zip remain.
- Consider expanding the commit message to briefly explain why the dependency is being reverted (e.g., compatibility or packaging issues) so future maintainers understand the rationale without digging through history.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the intent is to fully revert the migration to 7zip, double‑check that all packaging targets (including the debian/control file and any build scripts) consistently depend on p7zip and no references to 7zip remain.
- Consider expanding the commit message to briefly explain why the dependency is being reverted (e.g., compatibility or packaging issues) so future maintainers understand the rationale without digging through history.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review这段代码变更主要涉及了 以下是对该变更的详细审查意见,涵盖语法逻辑、代码质量、性能和安全性: 1. 语法逻辑与规范性
2. 代码质量
3. 代码性能
4. 代码安全
5. 综合改进意见
总结: |
This reverts commit 4764b67.
Summary by Sourcery
Restore the runtime dependency on the legacy p7zip package instead of 7zip in the RPM packaging metadata.
Bug Fixes:
Build: