Skip to content

fix: use desktop-id as fallback name for ill-formed desktop entries #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
Feb 3, 2026
Merged

fix: use desktop-id as fallback name for ill-formed desktop entries #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ddeintegration/appmgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ static AppMgr::AppItem *parseDBus2AppItem(const ObjectInterfaceMap &source)
parseDBusField<QStringMap>(appInfo, u8"Name").value(),
parseDBusField<QStringMap>(appInfo, u8"GenericName").value());

// just in case the entry is ill-formed, doesn't have a valid display name, fallback to use its desktop-id instead.
if (item->displayName.isEmpty()) {
item->displayName = item->id;
}
Comment on lines +97 to +100
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Treat whitespace-only display names as empty before applying the desktop-id fallback.

Because this uses isEmpty(), a display name containing only spaces or other whitespace will not fall back and will likely render poorly. Please use item->displayName.trimmed().isEmpty() so whitespace-only values also trigger the desktop-id fallback.

Suggested change
// just in case the entry is ill-formed, doesn't have a valid display name, fallback to use its desktop-id instead.
if (item->displayName.isEmpty()) {
item->displayName = item->id;
}
// just in case the entry is ill-formed, doesn't have a valid display name (or only whitespace),
// fallback to use its desktop-id instead.
if (item->displayName.trimmed().isEmpty()) {
item->displayName = item->id;
}


if (auto value = parseDBusField<QStringMap>(appInfo, u8"Name")) {
item->name = parseName(value.value());
}
Expand Down