ground-rules: Add LTP build system rule#7
ground-rules: Add LTP build system rule#7metan-ucw wants to merge 2 commits intolinux-test-project:masterfrom
Conversation
This was missing from the file. Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
| `env_pre.mk` + `generic_trunk_target.mk` instead and recurse into | ||
| subdirectories automatically. | ||
|
|
||
| **Open POSIX testsuite** (`testcases/open_posix_testsuite/`) has its own |
There was a problem hiding this comment.
This requires a different section specific to Open posix testing suite.
| ### Building a Single Test | ||
|
|
||
| ```sh | ||
| make -C testcases/kernel/syscalls/epoll_wait epoll_wait01 |
There was a problem hiding this comment.
Unfortunately this is error prone. If LLM tries to compile the test, it will mess up everything if model is not smart enough, because the example is specific to epoll_wait testing suite. I would just remove this part, or use the syntax we have in ltp-review-smoke skill.
| ``` | ||
|
|
||
| This runs `scripts/checkpatch.pl` (coding style) and `tools/sparse/sparse-ltp` | ||
| (static analysis) on the source files. |
There was a problem hiding this comment.
Also this section is already described in the ltp-review-smoke skill.
| Per-target flags can be added as: | ||
|
|
||
| ```make | ||
| epoll_wait02: LDLIBS += -lrt |
There was a problem hiding this comment.
And also this is error prone.
| make install # install to /opt/ltp (default) | ||
| ``` | ||
|
|
||
| ### Test Makefiles |
There was a problem hiding this comment.
This is already explained in the c-tests.md, so we are duplicating information.
| accept02: CFLAGS += -pthread | ||
| ``` | ||
|
|
||
| ## Additional Resources |
There was a problem hiding this comment.
Uff....I'm a bit puzzled, because we are giving info to the LLM to watch into the build_system.rst file contained in the LTP doc/ folder. But documentation in LTP is not generic enough to give a "dumb" LLM instructions for compiling tests or verifying the build system correctness.
I'm starting to think we should probably take the LTP build system documentation and update it so we can read it properly with an LLM, avoiding specific implementations. Then, the AGENTS.md will just point to it as it is now and we should achieve this task.
To make the LTP documentation as generic as possible, we should probably take ltp-review-smoke as example.
2 participants
Tests must use LTP build system.