refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update Ansible fact usage to be compatible with INJECT_FACTS_AS_VARS=false and newer Ansible versions.

Documentation:

• Clarify README-ostree fact variable examples to use ansible_facts[...] keys instead of deprecated top-level fact variables.

Tests:

• Adjust test playbooks and test vars to reference distribution-related data via ansible_facts[...] rather than deprecated fact variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors Ansible usage to stop relying on deprecated fact variables and instead use the supported ansible_facts mappings in templates, conditionals, tests, and documentation, to be compatible with INJECT_FACTS_AS_VARS=false in Ansible 2.20+.

File-Level Changes

Change	Details	Files
Replace deprecated fact variables with ansible_facts lookups in tests and vars files to support INJECT_FACTS_AS_VARS=false.	Update commented example Jinja expressions in test playbook to reference ansible_facts keys instead of bare Ansible fact variables. Adjust test vars that check whether the distribution is a Red Hat or Fedora derivative to use ansible_facts['distribution'] in conditionals. Mirror the same ansible_facts-based conditional logic in the main vars file used by the role.	tests/tests_include_vars_from_parent.yml tests/vars/rh_distros_vars.yml vars/main.yml
Align documentation with new ansible_facts-based fact access pattern.	Update README to describe DISTRO-VERSION in terms of ansible_facts['distribution'] and ansible_facts['distribution_version'] rather than deprecated ansible_distribution variables.	README-ostree.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In tests_include_vars_from_parent.yml, you now mix ansible_facts['distribution'] with the existing facts['distribution'] usage in the same block; consider standardizing on one approach (likely ansible_facts[...]) for consistency and to avoid confusion.
• In README-ostree.md, you updated the description to use ansible_facts[...]; consider checking for any remaining references to the old ansible_distribution/ansible_distribution_version style elsewhere in the repo to keep the guidance consistent.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `tests_include_vars_from_parent.yml`, you now mix `ansible_facts['distribution']` with the existing `facts['distribution']` usage in the same block; consider standardizing on one approach (likely `ansible_facts[...]`) for consistency and to avoid confusion.
- In `README-ostree.md`, you updated the description to use `ansible_facts[...]`; consider checking for any remaining references to the old `ansible_distribution`/`ansible_distribution_version` style elsewhere in the repo to keep the guidance consistent.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}