refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update Ansible role and tests to use the new ansible_facts-based fact access instead of legacy fact variables for compatibility with INJECT_FACTS_AS_VARS=false.

Enhancements:

• Replace uses of legacy fact variables (e.g., ansible_distribution, ansible_memory_mb) with ansible_facts lookups across role variables, templates, and tests to align with Ansible 2.20+ behavior.

Documentation:

• Adjust OSTree README documentation to describe DISTRO-VERSION in terms of ansible_facts-based keys instead of deprecated fact variables.

Tests:

• Update test playbooks and vars to validate behavior using ansible_facts-based access patterns, including memory and distribution checks.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors Ansible variable usage to rely on the ansible_facts dictionary instead of injected fact variables, updating role variables, templates, tests, and documentation to be compatible with INJECT_FACTS_AS_VARS=false and Ansible 2.20+ deprecations.

Flow diagram for updated use of ansible_facts in PostgreSQL role

flowchart TD
  AnsiblePlaybook[Ansible playbook] --> GatherFacts[Gather facts]
  GatherFacts --> ansible_facts[ansible_facts dict]

  ansible_facts --> RequiredFactsVars[Set __postgresql_required_facts using ansible_facts keys]
  ansible_facts --> NoSubsetFactsVars[Set __postgresql_no_subset_facts using memory_mb]

  RequiredFactsVars --> CheckRequiredFacts[Check required facts present]
  NoSubsetFactsVars --> CheckRequiredFacts

  CheckRequiredFacts -->|missing distribution or memory_mb| FailTask[Fail task or gather extra subsets]
  CheckRequiredFacts -->|all present| UseFacts[Use ansible_facts in role]

  UseFacts --> DistroFlags[Compute __postgresql_is_rh_distro and __postgresql_is_rh_distro_fedora from ansible_facts.distribution]
  UseFacts --> TuningTemplate[Render postgresql-internal.conf.j2 using ansible_facts.memory_mb]

  DistroFlags --> RoleConditionals[Role conditionals based on distro]
  TuningTemplate --> PostgresqlConf[postgresql-internal.conf]

Loading

File-Level Changes

Change	Details	Files
Replace deprecated fact variables with ansible_facts lookups across role vars, templates, and tests.	Update commented example in include-vars test to use ansible_facts['distribution'] and related keys instead of ansible_distribution-style variables. Adjust required fact names from ansible_memory_mb to memory_mb and align no-subset fact configuration accordingly. Change Red Hat distro detection helpers to reference ansible_facts['distribution'] in both role vars and test vars. Update README-ostree documentation to describe DISTRO-VERSION in terms of ansible_facts["distribution"] and ansible_facts["distribution_version"]. Modify PostgreSQL tuning template and associated tests to compute memory-based settings using ansible_facts.memory_mb rather than ansible_memory_mb.	tests/tests_include_vars_from_parent.yml vars/main.yml README-ostree.md templates/postgresql-internal.conf.j2 tests/tasks/install_and_check.yml tests/vars/rh_distros_vars.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[richm]

[citest]

[sourcery-ai]

Hey - I've left some high level feedback:

• The PR mixes bracket and attribute access for facts (e.g., ansible_facts['distribution'] vs ansible_facts.memory_mb); consider standardizing on one style (typically bracket access) for consistency and to avoid surprises with complex or nested facts.
• In tests/tests_include_vars_from_parent.yml, the comment now refers to ansible_facts['distribution'] while the actual expression still uses facts['distribution']; consider aligning the comment with the implementation to avoid confusion for future readers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The PR mixes bracket and attribute access for facts (e.g., `ansible_facts['distribution']` vs `ansible_facts.memory_mb`); consider standardizing on one style (typically bracket access) for consistency and to avoid surprises with complex or nested facts.
- In `tests/tests_include_vars_from_parent.yml`, the comment now refers to `ansible_facts['distribution']` while the actual expression still uses `facts['distribution']`; consider aligning the comment with the implementation to avoid confusion for future readers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[richm]

[citest]