Open
Conversation
Basic functionality of kernel settings report module
Move everything to python functionality instead of using shell scripts, change the format of the output to be more consistent with kernel_settings role input, filter out some known unstable values
Also convert unstable settings list to regex for more flexibility
Simple two host test to apply kernel settings output from kernel_report module to another machine
Assumes that two images will be specified as TEST_SUBJECTS: One CentOS image and one Fedora image
Taken from the tuned documentation and existing profiles, support added for more parameters which the kernel_settings role should allow users to change
Update apply_kernel_report_settings test
Add special logic so that if one of these values is read in as '0', the kernel_report plugin will ignore it and only populate one of the bytes/ratio fields
Tested with two Fedora machines sharing an identical release
Collaborator
|
[citest commit:ed44dbad1e58faef5a4ca4a2db2e6cdcd0691dfe] |
Contributor
|
[citest pending] |
1 similar comment
Collaborator
|
[citest pending] |
Collaborator
|
[citest bad] |
Collaborator
|
[citest pending] |
3 similar comments
Collaborator
|
[citest pending] |
Collaborator
|
[citest pending] |
Collaborator
|
[citest pending] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New kernel_report module to pull settings from an existing template machine and apply them to a number of target machines. This also required adding "device-specific" support to the existing kernel_settings system role so that, similar to tuneD, it allows for changing kernel settings that are associated with particular devices.
A few notes about the PR and outstanding items that will need to be reviewed before merging:
defaults/main.yml, though the README should probably include it since this was significant formatting changesysctlfields from Joe Mario that can be added to the list kernel_report module and tested (I will link a corresponding issue to this PR)