ci: ansible-lint - remove .collection directory from converted collection [citest_skip]

[richm]

The new ansible-lint@v26 does not like it when there is a .collection directory
with a galaxy.yml in the converted collection, so remove it, since it is not
needed for ansible-lint.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

• Extend the cleanup step in the ansible-lint workflow to delete the converted collection's .collection directory in addition to existing temporary paths.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the ansible-lint CI workflow cleanup to also remove the converted collection's .collection directory, which is no longer needed and conflicts with ansible-lint v26.

Sequence diagram for updated ansible-lint CI cleanup workflow

sequenceDiagram
    actor Developer
    participant GitHubActions
    participant Runner
    participant Tox
    participant AnsibleCollectionDir as Ansible_collection_directory
    participant AnsibleLint as ansible_lint_v26

    Developer->>GitHubActions: Push or open PR
    GitHubActions->>Runner: Start ansible-lint workflow job
    Runner->>Tox: Run lsr_ci_runtox with TOXENV=collection
    Tox-->>Runner: Converted collection created at coll_dir

    note over Runner,AnsibleCollectionDir: Updated cleanup step
    Runner->>AnsibleCollectionDir: rm -rf coll_dir/.ansible
    Runner->>Runner: rm -rf .tox/ansible-plugin-scan
    Runner->>AnsibleCollectionDir: rm -rf coll_dir/.collection

    Runner->>AnsibleCollectionDir: mkdir -p coll_dir/.git
    Runner->>AnsibleLint: Invoke ansible-lint action on coll_dir
    AnsibleLint-->>Runner: Lint results
    Runner-->>GitHubActions: Job status
    GitHubActions-->>Developer: Report CI status

Loading

Flow diagram for ansible-lint CI job with .collection removal

flowchart TD
    A[Developer pushes commit or opens PR] --> B[GitHub Actions triggers ansible-lint workflow]
    B --> C[Run lsr_ci_runtox with TOXENV=collection]
    C --> D[Converted collection created at coll_dir]
    D --> E[Cleanup: remove coll_dir/.ansible]
    E --> F[Cleanup: remove .tox/ansible-plugin-scan]
    F --> G[Cleanup: remove coll_dir/.collection]
    G --> H[Prepare for ansible-lint: mkdir -p coll_dir/.git]
    H --> I[Run ansible-lint v26 GitHub Action on coll_dir]
    I --> J[Report CI status back to GitHub]

Loading

File-Level Changes

Change	Details	Files
Update CI ansible-lint workflow cleanup to delete the converted collection's .collection directory after tox runs.	Adjust the cleanup rm -rf command in the ansible-lint job to include the collection-specific .collection directory alongside existing artifacts .collection path is constructed using the same coll_dir variable as other converted collection artifacts to ensure correct target	.github/workflows/ansible-lint.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}