Build nvme have#3404
Merged
Merged
Conversation
Since actually the attribute checked by meson as if supported. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
build-nvme-have
branch
2 times, most recently
from
a97a04b to
a432966
Compare
igaw
reviewed
Jun 1, 2026
| ) | ||
|
|
||
| conf.set('NVME_HAVE_SENDFILE', cc.has_function('sendfile')) | ||
| conf.set('NVME_NVME_HAVE_SENDFILE', cc.has_function('sendfile')) |
Collaborator
There was a problem hiding this comment.
This already has the correct prefix, so no need to add another prefix.
igaw
reviewed
Jun 1, 2026
| conf.set('NVME_NVME_HAVE_SENDFILE', cc.has_function('sendfile')) | ||
|
|
||
| conf.set('NVME_HAVE_MMAP', cc.has_function('mmap')) | ||
| conf.set('NVME_NVME_HAVE_MMAP', cc.has_function('mmap')) |
Collaborator
There was a problem hiding this comment.
Same here, it alreayd has the NVME prefix.
Collaborator
|
looks good, just the two double prefixes need to be dropped. |
Still remaining some HAVE_FOO defines used by ccan. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
build-nvme-have
branch
from
a432966 to
84a7cd9
Compare
Contributor
Author
|
Just fixed the patch as mentioned. Sorry for the error. Thank you. |
Collaborator
|
No worries, that's why we have reviews. Thanks for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.