completions: fix ocp plugin command list and description#3385
Merged
Conversation
Fix bash completion for the ocp plugin: - Correct "clear-pcie-correctable-error-counters" to "clear-pcie-correctable-errors" - Correct "vs-fw-activate-history" to "fw-activate-history" - Add missing commands: error-recovery-log, unsupported-reqs-log, tcg-configuration-log, set-plp-health-check-interval, get-plp-health-check-interval, get-enable-ieee1667-silo, set-enable-ieee1667-silo, persistent-event-log, get-idle-wakeup-time - Add "version" and "help" commands Also fix the misleading description for get-clear-pcie-correctable-errors in ocp-nvme.h to clarify it retrieves the feature value rather than clearing the counters. Signed-off-by: Jim Munn <jlmunn@micron.com>
Collaborator
|
Could you also update the zsh binding ( |
Update zsh completions for the ocp plugin to include all commands
with descriptions matching the plugin header.
Normalize descriptions across ocp-nvme.h, ocp-nvme.c, and
ocp-clear-features.c:
- Use title case consistently
- Use "Retrieve" for log page commands, "Get/Set" for features
- Remove erroneous "Define" prefix from "Issue Get/Set Feature" strings
- Normalize "FID :" spacing to "FID:"
- Expand abbreviations (Async -> Asynchronous, Config -> Configuration)
- Fix odd phrasings ("Return set of..." -> "Get ... Feature")
Signed-off-by: Jim Munn <jlmunn@micron.com>
Contributor
Author
|
I added zsh completions and did a bunch of cleanup of descriptions in the process. |
Collaborator
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bash completion for the ocp plugin:
Also fix the misleading description for get-clear-pcie-correctable-errors in ocp-nvme.h to clarify it retrieves the feature value rather than clearing the counters.