Open
Conversation
The UUID used by the SN640 and SN655 drives was not being checked in the sandisk plugin code. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
2 Sandisk drives do support the Clear Assert VUC but did not capability enabled. This change will enable it. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
The data-area parameter was being overwritten and set to the default data area value for all cases. This change will only set it when it's not specified. This set of changes fully deprecates a few of the optional parameters for this command across both WDC and Sandisk plugins, and tidies up some of the logic around how telemetry or vendor defined debug is returned. This adds a new --type value in the vs-internal-log command for capturing Host-initiated and Controller-initated telemetry in one command. Signed-off-by: Brandon Paupore <brandon.paupore@sandisk.com> Fixes a compile warning on tar file creation. Fixes error that creates an empty file. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains fixes or changes for the following issues: