feat: fix bugs in arbitration and power-thresh commands#3118
Open
jimmunn wants to merge 1 commit intolinux-nvme:masterfrom
Open
feat: fix bugs in arbitration and power-thresh commands#3118jimmunn wants to merge 1 commit intolinux-nvme:masterfrom
jimmunn wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
arbitration_set() used temp_thresh_feat instead of arbitration_feat in the error path, and feat_arbitration() passed TEMP_THRESH_DESC instead of ARBITRATION_DESC to parse_and_open(). power_thresh_set() used __u8 instead of __u16 for the ptv parameter, truncating the power threshold value. Signed-off-by: Jim Munn <jlmunn@micron.com>
Contributor
|
Looks good. Thank you for your fix. Sorry for the errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arbitration_set() used temp_thresh_feat instead of arbitration_feat in the error path, and feat_arbitration() passed TEMP_THRESH_DESC instead of ARBITRATION_DESC to parse_and_open().
power_thresh_set() used __u8 instead of __u16 for the ptv parameter, truncating the power threshold value.