Open
Conversation
The libnvme.h header is not a local header file, thus use the standard lookup <> for external headers. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Use the set feature defines instead of the identify. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
header-mania
branch
2 times, most recently
from
375efdf to
d239f84
Compare
Unify the header includes. Use the libnvme.h or/and libnvme-mi.h everywhere instead indiviual headers. This makes the refactoring of the headers simpler (splitting them into smaller ones). Signed-off-by: Daniel Wagner <wagi@kernel.org>
clang reports these are unused, thus remove them from the include list. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Use nvme_ns_rescan which wraps the IOCTL. This in preparation to make the low level code private in libnvme. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Don't expose these low level defines anymore. The library should provide all necessary functions/helpers. Signed-off-by: Daniel Wagner <wagi@kernel.org>
These data structs are libnvme APIs and just match the Linux APIs. libnvme should not expose directly the Linux data structs. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Split the ioctl APIs from the commands API. While at it, also remove a few of the unnecessary header dependencies. The aim here is to make the ioctl header as small as possible. This will make any porting attempts simpler. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides splitting the ioctl API and the nvme API definitions it will make any porting attempt of the library simpler.