refactor fabrics: move discovery and connect logic code to the library #3017
+2,223
−1,338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a useful helper which can be reused inside the library as well. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This is generic code for discovery, thus move it the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Move more of the discovery code from nvme-cli to the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Move the connect config json code to the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
refactor-fabrics
branch
from
ac1eab5 to
2e119f9
Compare
Move more discovery code to the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The host_traddr and host_iface are property of the controller not of the fabric configuration. Because the discovery API was stable, it ended up in the fabric configuration. The discovery API is reworked thus we can move it to where it actually belongs. See also 9a4dd38 ("Move 'host_traddr' and 'host_iface' into fabrics configuration"). Signed-off-by: Daniel Wagner <wagi@kernel.org>
The NVMF_ARGS macro parses the common arguments for the transport configuration. Move all those open coded variables into a context, so it's simpler to pass a complete configuration around. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Move the discovery config file to the library. Add a callback interface to retrieve the next line to execute. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The final discovery logic can be moved to the library now. This leaves the nvme-cli with just the parsing operations and setting up the discovery context and then the whole logic happens in the library. The APIs are not final there are very rough and these need more cleanups. But the important tasks was to move the logic code into the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The connect and discovery APIs use a lot of common context information. Thus generalize the discovery context into nvmf_context which then can be used by either APIs types. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Move more of the logic code into the library. Drop the nvmf_ prefix for the commands in nvme-cli so we can use it for the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
refactor-fabrics
branch
from
2e119f9 to
0c978aa
Compare
There a arguments which are already stored in the nvmf_context object, thus we can remove those. While at it, also remove the host lookup and configuring code to the library. Besides making the API more consistent it also more generic code to the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
refactor-fabrics
branch
2 times, most recently
from
7b12a63 to
e2286c6
Compare
Document the new APIs. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
refactor-fabrics
branch
from
e2286c6 to
aadec98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to really split the logic from the parsing code move the discovery and connect code to the library. Since some interaction between nvme-cli and library is necessary introduce a
struct nvmf_contextobject which holds the configuration state and also callbacks. Since it should be extensible in future, don't expose the data structure. Just introduce setters for it. If we need to extend it, we can just add new setters and don't break existing code.This series doesn't not really cleanup the existing code, it just moving around and starts introducing this new API. It needs more work but I think it's better to built on top of it instead trying to do all in one go.
This survives simple testing.