Merged
Conversation
Signed-off-by: Michal Rábek <mrabek@redhat.com>
This patch moves the conditional tagging functionality from release.yml to build.yml. The workflow is now as follows: - new staging containers are always tagged with :next - new CI containers are always tagged with :next - on a tag push - staging containers are always tagged with :main - CI containers are always tagged with :latest - CI containers are tagged with the tag's name (version number) Signed-off-by: Michal Rábek <mrabek@redhat.com>
Staging Dockerfiles should be generated by the 'generate' target too. There is not good reason to segregate this, since file generation is much faster than container builds (which should be segregated into main and staging groups). Signed-off-by: Michal Rábek <mrabek@redhat.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes major reorganization of this repository. Dockerfiles are now separated into directories
mainandstaging. All of them except cross compiler images are generated withmake generareand built withmake build.GitHub workflows have been minimized and conditional tagging of build container images has been added.