drivers: ftdi-gpio: Add second USB disconnect GPIO & schema.yaml fixes #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unevaluatedItems is for array items, we need unevaluatedProperties here. But actually this can just be additionalProperties.
"patternProperties" must be on the same indentation level as "properties", otherwise it just defines a property called "patternProperties" in cdba.yaml. Also add additionalProperties: false, so properties not matching the regex are actually disallowed and reported.
Some boards have more than one USB port. In that case, there is a second GPIO on the debug board to simulate a USB disconnection for those. Add the option to describe both USB disconnect GPIOs using "usb0_disconnect" and "usb1_disconnect" and change both of them when disabling USB power. In the future it might be useful to control them separately, but for now this ensures that power to the board is cut properly when the board is powered off.
stephan-gh
force-pushed
the
ftdi-usb1
branch
from
4556a32 to
7209229
Compare
superna9999
approved these changes
Feb 14, 2025
Member
superna9999
left a comment
superna9999
left a comment
There was a problem hiding this comment.
Nice catch, thx for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some boards have more than one USB port. In that case, there is a second
GPIO on the debug board to simulate a USB disconnection for those.
Add the option to describe both USB disconnect GPIOs using
"usb0_disconnect" and "usb1_disconnect" and change both of them
when disabling USB power.
In the future it might be useful to control them separately, but for now
this ensures that power to the board is cut properly when the board is
powered off.
Also fix some mistakes in
schema.yamlthat prevented actually validating the properties belowftdi_gpio.Cc: @superna9999