device_parser: improve error reporting #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumag
requested changes
Feb 11, 2025
Collaborator
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Could you please rephrase commit message to use imperative language. In other words, "This patch adds" -> "Add".
Add more verbose output to config file parsing errors. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Contributor
Author
Fixed. I split the long lines, but I'm not sure this is done "the right way". I didn't find any other long lines in the code to follow the style. Let me know what is the preferred way here. |
lumag
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds more verbose output to config file parsing errors.