testsuite/init_module: Handle __NR_riscv_hwprobe in syscall wrapper #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function move_module() uses the variable t to track how many memory types it has allocated and consequently how many should be freed if an error occurs. The variable is initially set to 0 and is updated when a call to module_memory_alloc() fails. However, move_module() can fail for other reasons as well, in which case t remains set to 0 and no memory is freed. Fix the problem by initializing t to MOD_MEM_NUM_TYPES. Additionally, make the deallocation loop more robust by not relying on the mod_mem_type_t enum having a signed integer as its underlying type. Fixes: c7ee8ae ("module: add stop-grap sanity check on module memcpy()") Signed-off-by: Petr Pavlu <petr.pavlu@suse.com> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Reviewed-by: Daniel Gomez <da.gomez@samsung.com> Link: https://lore.kernel.org/r/20250618122730.51324-2-petr.pavlu@suse.com Signed-off-by: Daniel Gomez <da.gomez@samsung.com> Message-ID: <20250618122730.51324-2-petr.pavlu@suse.com>
All error conditions in move_module() set the return value by updating the ret variable. Therefore, it is not necessary to the initialize the variable when declaring it. Remove the unnecessary initialization. Signed-off-by: Petr Pavlu <petr.pavlu@suse.com> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Reviewed-by: Daniel Gomez <da.gomez@samsung.com> Link: https://lore.kernel.org/r/20250618122730.51324-3-petr.pavlu@suse.com Signed-off-by: Daniel Gomez <da.gomez@samsung.com> Message-ID: <20250618122730.51324-3-petr.pavlu@suse.com>
Author
|
Upstream branch: f4e47f3 Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/linux-modules/list/?series=977352 conflict: |
dkruces
force-pushed
the
modules-next_base
branch
2 times, most recently
from
b4d1c4e to
61dc34e
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
2 times, most recently
from
1df8185 to
9aab33d
Compare
dkruces
force-pushed
the
modules-next_base
branch
from
9aab33d to
99d099e
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
99d099e to
3aed49d
Compare
dkruces
force-pushed
the
modules-next_base
branch
from
3aed49d to
856647c
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
856647c to
e1b99f5
Compare
dkruces
force-pushed
the
modules-next_base
branch
from
e1b99f5 to
856647c
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
4 times, most recently
from
cdc6b9e to
311def7
Compare
dkruces
force-pushed
the
modules-next_base
branch
from
311def7 to
1107cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: testsuite/init_module: Handle __NR_riscv_hwprobe in syscall wrapper
version: 1
url: https://patchwork.kernel.org/project/linux-modules/list/?series=977352