gce: Set correct boot disk type for C4 and C4A machine series #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCE fourth-generation machine families (C4, C4A, N4) require Hyperdisk for boot disks; they do not support Persistent Disk types like pd-balanced. The current Kconfig.machine.default incorrectly defaults to pd-balanced for all machine families, causing VM creation to fail for C4 and C4A instances. Each series in SERIES_METADATA now includes a boot_disk_type property specifying the correct disk type for that machine family. The machine_type.j2 template generates TERRAFORM_GCE_IMAGE_TYPE with the appropriate value, ensuring generated Kconfig files contain correct settings. The Kconfig.machine.default file updates C4_HIGHCPU, C4_STANDARD, C4A_HIGHCPU, C4A_HIGHMEM, and C4A_STANDARD to use hyperdisk-balanced. Older machine series retain pd-balanced since they support Persistent Disk. Generated-by: Claude AI Signed-off-by: Chuck Lever <cel@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCE fourth-generation machine families (C4, C4A, N4) require Hyperdisk for boot disks; they do not support Persistent Disk types like pd-balanced. The current Kconfig.machine.default incorrectly defaults to pd-balanced for all machine families, causing VM creation to fail for C4 and C4A instances.
Each series in SERIES_METADATA now includes a boot_disk_type property specifying the correct disk type for that machine family. The machine_type.j2 template generates TERRAFORM_GCE_IMAGE_TYPE with the appropriate value, ensuring generated Kconfig files contain correct settings.
The Kconfig.machine.default file updates C4_HIGHCPU, C4_STANDARD, C4A_HIGHCPU, C4A_HIGHMEM, and C4A_STANDARD to use hyperdisk-balanced. Older machine series retain pd-balanced since they support Persistent Disk.