Refactor playbooks/roles/terraform/tasks/main.yml #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terraform role's main.yml had grown to nearly 800 lines with Lambda Labs and DataCrunch provider-specific logic interleaved throughout the file. This made maintenance difficult and required understanding the entire file to make changes for a single provider. This refactoring creates a plugin-like architecture where each cloud provider's unique requirements are isolated in dedicated task files. The new structure separates concerns by operation (bringup, destroy) and by provider (lambdalabs, datacrunch, generic), making it straightforward to add support for new providers or modify existing ones without risk of breaking other providers. Common functionality shared across all providers, such as SSH configuration and status reporting, is now cleanly separated in a common directory. This follows patterns already established in other roles like bootlinux and guestfs. Generated-by: Claude AI Signed-off-by: Chuck Lever <cel@kernel.org>
The cel@kernel address now points to an email service that handles plaintext email properly. Signed-off-by: Chuck Lever <cel@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up terraform/tasks/main.yml to make it easier to maintain.