nvme: Add test for sending admin commands over disabled paths #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hreinecke
force-pushed
the
admin-cmds
branch
2 times, most recently
from
8c6224a to
05fbdf9
Compare
ANA states only apply to commands to individual namespaces, not to commands for the controller. So add a testcase to check if we can send admin commands over inaccessible paths. Signed-off-by: Hannes Reinecke <hare@kernel.org>
igaw
reviewed
Jun 2, 2025
| ns=$(_find_nvme_ns "${def_subsys_uuid}") | ||
| [ -z "${ns}" ] && return 1 | ||
| nvme nvm-id-ctrl "/dev/${ns}" | ||
| nvme nvm-id-ns "/dev/${ns}" |
Contributor
There was a problem hiding this comment.
Everytime nvm-id-ctrl or nvm-id-ns is touched this test will break. I think it would be better to test for expected values.
Collaborator
There was a problem hiding this comment.
I ran this test case, and observed the failure message below:
nvme/064 (tr=loop) (test admin commands on disabled paths) [failed]
runtime 0.450s ... 1.114s
--- tests/nvme/064.out 2025-06-02 20:38:46.278859422 +0900
+++ /home/shin/Blktests/blktests/results/nodev_tr_loop/nvme/064.out.bad 2025-06-05 15:23:54.194590517 +0900
@@ -6,16 +6,22 @@
dmrl : 0
dmrsl : 0
dmsl : 0
+kpiocap: 0
+wzdsl : 0
+aocs : 0
+ver : 0x0
...
(Run 'diff -u tests/nvme/064.out /home/shin/Blktests/blktests/results/nodev_tr_loop/nvme/064.out.bad' to see the entire diff)
It looks that the new fields that nvme-id-ctrl and nvme-idns commands report are causing the failure.
Contributor
There was a problem hiding this comment.
To make this test a bit future proof, it really should check for specific fields, as we do in nvme/059:
nvme_awupf=$(nvme id-ctrl /dev/"${ctrl_dev}" | grep awupf | awk '{ print $3}')BTW, I still think we should start using the json output for nvme-cli together with jq, e.g:
nvme id-ctrl /dev/nvme0 --output json | jq .awupf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANA states only apply to commands to individual namespaces, not to commands for the controller. So add a testcase to check if we can send admin commands over inaccessible paths.