-
Notifications
You must be signed in to change notification settings - Fork 86
[draft]add new case for NVMe namespace management #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
70723e2 to
0e74c50
Compare
tests/nvme/064
Outdated
| nn=$(nvme id-ctrl /dev/"$ctrl_dev" | grep ^nn | awk '{ print $3}') | ||
| tnvmcap=$(nvme id-ctrl /dev/"$ctrl_dev" | grep tnvmcap | awk '{ print $3}') | ||
| lbaf=$(nvme id-ns "$TEST_DEV" | grep 'in use' | awk '{ print $2}') | ||
| lbads=$(nvme id-ns -H "$TEST_DEV" | grep 'in use' | awk '{ print $12}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use --verbose instead of the old --human-readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, to check the Data Size, the --verbose cannot output that value of 512[1], it only output "ds":9[2], not sure if it's something we can improve on nvme-cli.
[1]
LBA Format 1 : Metadata Size: 8 bytes - Data Size: 512 bytes - Relative Performance: 0x3 Degraded (in use)
[2]
"lbafs":[
{
"ms":0,
"ds":9,
"rp":1
},
{
"ms":8,
"ds":9,
"rp":3
},
{
"ms":0,
"ds":12,
"rp":0
},
{
"ms":8,
"ds":12,
"rp":2
},
{
"ms":64,
"ds":12,
"rp":3
}
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely something we can improve in nvme-cli. I understand that the verbose json output is lacking some information which is shown with stdout and verbose? Anyway, would you mind to open a bug report in nvme-cli so we don't forget about it. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I've filed below issue to track it.
linux-nvme/nvme-cli#2811
|
Generally I would prefer if we would start using the JSON output instead the STDOUT of nvme-cli. The JSON output is there for machine parsing. This would mean we add dependency on something like |
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
Thanks, just update to get the value from json ouput. |
|
Thanks for the patch. I have two comments:
|
No description provided.