Skip to content

TPT-4240: Remove LKE cluster dashboard function, tests, and related fixture#975

Open
zliang-akamai wants to merge 1 commit into
proj/linodego_v2from
zhiwei/remove-lke-dashboard
Open

TPT-4240: Remove LKE cluster dashboard function, tests, and related fixture#975
zliang-akamai wants to merge 1 commit into
proj/linodego_v2from
zhiwei/remove-lke-dashboard

Conversation

@zliang-akamai
Copy link
Copy Markdown
Member

📝 Description

As requested by the LKE team, removing this deprecated API in linodego v2.

@zliang-akamai zliang-akamai requested a review from a team as a code owner May 21, 2026 23:53
Copilot AI review requested due to automatic review settings May 21, 2026 23:53
@zliang-akamai zliang-akamai requested a review from a team as a code owner May 21, 2026 23:53
@zliang-akamai zliang-akamai requested review from psnoch-akamai and yec-akamai and removed request for a team May 21, 2026 23:53
@zliang-akamai zliang-akamai changed the title Remove LKE cluster dashboard function, tests, and related fixture TPT-4240: Remove LKE cluster dashboard function, tests, and related fixture May 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated LKE cluster dashboard API surface from linodego v2, along with the associated unit/integration tests and recorded fixtures.

Changes:

  • Removed GetLKEClusterDashboard client method and the LKEClusterDashboard response type.
  • Deleted unit/integration tests covering the dashboard endpoint.
  • Removed the unit JSON fixture and the go-vcr integration YAML cassette for the dashboard test.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lke_clusters.go Removes the exported dashboard type and client method for the deprecated dashboard endpoint.
test/unit/lke_clusters_test.go Deletes the unit test that exercised GetLKEClusterDashboard.
test/unit/fixtures/lke_cluster_dashboard.json Removes the no-longer-used unit test fixture.
test/integration/lke_clusters_test.go Deletes the integration test and drops the now-unused net/url import.
test/integration/fixtures/TestLKECluster_Dashboard_Get.yaml Removes the recorded integration cassette for the deleted test.
Comments suppressed due to low confidence (1)

lke_clusters.go:277

  • Removing GetLKEClusterDashboard/LKEClusterDashboard is a breaking change for consumers of the Go client (compile-time API removal). Please ensure this removal is called out prominently in the release notes / upgrade guidance for the next release so downstream users can migrate accordingly.
// RecycleLKEClusterNodes recycles all nodes in all pools of the specified LKE Cluster.
func (c *Client) RecycleLKEClusterNodes(ctx context.Context, clusterID int) error {
	e := formatAPIPath("lke/clusters/%d/recycle", clusterID)
	return doPOSTRequestNoRequestResponseBody(ctx, c, e)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants