TPT-4240: Remove LKE cluster dashboard function, tests, and related fixture#975
Open
zliang-akamai wants to merge 1 commit into
Open
TPT-4240: Remove LKE cluster dashboard function, tests, and related fixture#975zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated LKE cluster dashboard API surface from linodego v2, along with the associated unit/integration tests and recorded fixtures.
Changes:
- Removed
GetLKEClusterDashboardclient method and theLKEClusterDashboardresponse type. - Deleted unit/integration tests covering the dashboard endpoint.
- Removed the unit JSON fixture and the go-vcr integration YAML cassette for the dashboard test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lke_clusters.go |
Removes the exported dashboard type and client method for the deprecated dashboard endpoint. |
test/unit/lke_clusters_test.go |
Deletes the unit test that exercised GetLKEClusterDashboard. |
test/unit/fixtures/lke_cluster_dashboard.json |
Removes the no-longer-used unit test fixture. |
test/integration/lke_clusters_test.go |
Deletes the integration test and drops the now-unused net/url import. |
test/integration/fixtures/TestLKECluster_Dashboard_Get.yaml |
Removes the recorded integration cassette for the deleted test. |
Comments suppressed due to low confidence (1)
lke_clusters.go:277
- Removing GetLKEClusterDashboard/LKEClusterDashboard is a breaking change for consumers of the Go client (compile-time API removal). Please ensure this removal is called out prominently in the release notes / upgrade guidance for the next release so downstream users can migrate accordingly.
// RecycleLKEClusterNodes recycles all nodes in all pools of the specified LKE Cluster.
func (c *Client) RecycleLKEClusterNodes(ctx context.Context, clusterID int) error {
e := formatAPIPath("lke/clusters/%d/recycle", clusterID)
return doPOSTRequestNoRequestResponseBody(ctx, c, e)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
As requested by the LKE team, removing this deprecated API in linodego v2.