Skip to content

Conversation

@ezilber-akamai
Copy link
Contributor

No description provided.

dependabot bot and others added 13 commits October 30, 2025 10:38
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* adding monitors in region endpoint

* updating with review comments

* fixing build issues

* fixing build issues

* fixing build issue

* fixing build issue

* fixing lint

* fixing filters

* adding int-test for filter and groupby
* Add alias support to Property class and related tests

- Introduced `alias_of` parameter in Property to allow aliasing of API attributes.
- Implemented `properties_with_alias` method in Base class to retrieve aliased properties.
- Updated BetaProgram to include an aliased property for "class".
- Added comprehensive tests for alias functionality in PropertyAliasTest.

* Update linode_api4/objects/base.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Pre-compute keys

* More readable condition

* make format

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* DI-26927 Python SDK code for GET Alert Definitions

* DI-26927 Python SDK code modified for client code

* DI-26927 Added Unit test cases and missing classes

* DI-26927 made corrections to keep code consistent

* DI-26927 Updated Unit and Integratoion Tests

* [dev 51950af] DI-26927 Updated Unit and Integratoion Tests

* Revert "DI-26927 Updated Unit and Integratoion Tests"

This reverts commit 51950af.

* Revert "[dev 51950af] DI-26927 Updated Unit and Integratoion Tests"

This reverts commit 6ca6a5a.

* DI-26927 Updated Unit and Integratoion Tests

* Remove .venv from repo and add to .gitignore

* DI-26927 reverted git ignore

* DI-26927 reverted conftest,py

* DI-26927  added accidentlly deleted file

* DI-26927 Corrected Integration and Unit Test cases for Alerting APIs

* DI-26927 Reverted conftest.py and check integration without those changes

* DI-26927 fixed integration test for firewall and added time for alert update before deletion

* DI-26927 fixed changing monitor.py as per review comments

* DI-26927 fixed changing monitor.py as per review comments

* DI-26927 fixed changing monitor.py as per review comments

* DI-26927 Intermediate change to address internal review comments

* DI-26927 CLosed review comments

* DI-26927 CLosed review comments

* DI-27156 closed review comments from Ketan

* DI-27156 closed review comments from Ketan

* DI-27156 fixed unit test cases post review comments fixes

* DI-27156 Updated docstring and make unit test cases changes

* DI-27156 Added unit test cases post review comments fixes

* DI-27156 Added unit test cases post review comments fixes

* tests(monitor): add MonitorAlertDefinitionsTest and update fixtures for alert-definitions

* DI-27156 Added unit test cases post review comments fixes

* DI-27156 Updated docstring

* DI-27156 Updated unit test errors

* removed unwanted files

* added missing doxcstring

* added missing doxcstring

* added missing doxcstring

* rmoved test files

* closed final review comments

* fixing integration test issues

* Corrected Integration Test Case

* DI-26927 Corrected json to object modifications issues

* DI-26927 Corrected json to object modifications issues

* DI-26927 Unit test corrections for mofied functions name

* Delete test/fixtures/monitor/services/dbaas/alert-definitions.json

Not Required

* Delete test.py

Not Required here required for local testing only

* Delete test/fixtures/monitor/alert-definitions.json

Not required here

* DI-26927 reverted fixtures.py as its not necesary to change

* DI-26927 reverted fixtures.py as its not necesary to change

* DI-26927 reverted fixtures.py as its not necesary to change

* DI-26927 fixed linting error

* DI-26927 fixed linting error

* DI-26927 fixed lint error caught in CI

* Update test/unit/groups/monitor_api_test.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/integration/models/monitor/test_monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/integration/models/monitor/test_monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/integration/models/monitor/test_monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update linode_api4/objects/monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* DI-26927 fixed copilot comments

* fixed review comments from APIv4 team

* fixed review comments from APIv4 team

* fixed review comments from APIv4 team

* fixed review comments from APIv4 team

* DI-26927 fixed review comments from API v4 team

* fixed review comments from APIv4 team

* fixed lint errors

* Update linode_api4/groups/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* Update linode_api4/groups/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* fixed review  errors

* fixed unittest

* fixed unittest

* fixed unittest

* fixed unittest

* fixed unittest

* fixed unittest

* added update use case to integration test

* Update linode_api4/objects/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* Update linode_api4/objects/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* Update linode_api4/objects/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* Update linode_api4/objects/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* fixed further review comments

* Updated  integration test

* Updated  integration test with more assert statements

* Fix Linode interfaces property (#604)

* Fix test for interfaces (#605)

* Fix test

* changed as per github-advanced-security comments

* fixed formatting errors using python black

* Migrate test fixtures discovery to be with pathlib (#599)

* Migrate test fixtures discovery to be with pathlib

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update linode_api4/objects/monitor.py

Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>

* Fixed Copilot comments on unit and integration tests

* corrected unit test assert statement

* Added comment as per copilot suggestion for save() and delete()

* resolved comments from copilot commented whereever not applicable

* Test: verify automatic GPG signing is working

* Incorporated copilot comments

* Removed serialisabel file from commit

* Fix Lint errors

* fixed review comments fo mutable

* fixed review comments  to keep it in line with SDK guidelines

* Addressed review comments on AlertDefinition class

* Comprehensive monitor API improvements and code quality fixes

- Removed unused imports and optimized import order
- Updated test cases for monitor integration
- Enhanced monitor objects with proper type annotations
- Improved monitor groups with better error handling
- Applied code review feedback and best practices

* Applied review comments across

* Comprehensive monitor API fixes and improvements

- Fixed json_object parameter issues in AlertDefinition properties
- Corrected list type annotations for AlertChannelEnvelope
- Updated integration tests with proper status handling for alert definitions
- Applied review comments for better code quality
- Enhanced type annotations and import organization
- Improved error handling in monitor group methods

* change entity id type as per review comments

* reverted copilot comments as per the suggestion unit and integration test passed after the changes

* removed unused imports

* removed unused imports

* Refactored integration test

* changed _class to alert_class as per review suggestions

* changed alert_class to service_class as per review suggestions

* Update linode_api4/objects/monitor.py

* Update test/integration/models/monitor/test_monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/integration/models/monitor/test_monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update linode_api4/groups/monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/integration/models/monitor/test_monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update linode_api4/groups/monitor.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update test/fixtures/monitor_alert-definitions.json

* Apply suggestion from @zliang-akamai

* Apply suggestion from @zliang-akamai

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com>
Co-authored-by: Zhiwei Liang <zliang@akamai.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v3...v4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v5...v7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add support for resource lock

* Add `__all__` for lock types

* Lock group and tests

* Fix tests

* Cleanup

* Cleanup

* Cleanup and fix

* Bring union back

* Update doc

* Fix test

* Remove default lock type to match API schema; fix tests

* make format

* Remove unused var in test
#625)

* Filter regions based on account availabilities in get_regions function

* Bypass account's region availabilities check when the token has no account access

* Make ALL_ACCOUNT_AVAILABILITIES a global constant

* Optimization
* Added support for Private Image Sharing features and unit tests

* Addressed PR comments

* Integration tests for private image sharing (#632)

* Create integration tests for share groups - part 1

* Create test test_try_to_add_member_invalid_token

* Update integration tests for private image sharing feature

* Apply code review sugestions

---------

Co-authored-by: Erik Zilber <ezilber@akamai.com>

---------

Co-authored-by: Pawel <100145168+psnoch-akamai@users.noreply.github.com>
@ezilber-akamai ezilber-akamai added the ignore-for-release PRs you do not want to render in the changelog label Jan 16, 2026
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner January 16, 2026 15:35
@ezilber-akamai ezilber-akamai requested review from lkowalsk-akamai-com and mawilk90 and removed request for a team January 16, 2026 15:35
@ezilber-akamai ezilber-akamai merged commit f0e3595 into main Jan 16, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release PRs you do not want to render in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants