Conversation
Contributor
|
Comparison of Helm chart templating output: # New file added: git-server/templates/httproute.yaml
# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml
# values-repo.yaml
|
j-zimnowoda
approved these changes
May 29, 2026
Contributor
j-zimnowoda
left a comment
There was a problem hiding this comment.
LGTM
I have renamed enableRoute => createHttpRoute
There was a problem hiding this comment.
Pull request overview
Exposes the in-cluster git-server via a Gateway API HTTPRoute at git.<domainSuffix>, attached to the shared platform HTTPS Gateway listener. Follows the same pattern used by Argo CD / Keycloak (chart-native HTTPRoute + Otomi values wiring via the shared routes.gotmpl snippet).
Changes:
- Adds a new
templates/httproute.yamlandhttproute.*defaults to thegit-serverchart. - Wires the route in
values/git-server/git-server.gotmplusing sharedparentRefs/annotationsfromhelmfile.d/snippets/routes.gotmpl, gated byapps.git-server.createHttpRoute. - Adds
createHttpRoutetovalues-schema.yamland defaults it totrueinhelmfile.d/snippets/defaults.yaml.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/git-server/templates/httproute.yaml | New chart-native HTTPRoute template with optional labels/annotations/additionalRules. |
| charts/git-server/values.yaml | Adds disabled-by-default httproute value block. |
| values/git-server/git-server.gotmpl | Wires the HTTPRoute when createHttpRoute is true, using the shared route snippet and git.<domainSuffix> hostname. |
| helmfile.d/snippets/defaults.yaml | Defaults apps.git-server.createHttpRoute: true. |
| values-schema.yaml | Adds createHttpRoute boolean to the apps.git-server schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR adds a HTTPRoute for the lightweight Git server.
🔍 Reviewer Notes
🧹 Checklist