Skip to content

feat: add httproute for git server#3293

Open
merll wants to merge 6 commits into
mainfrom
APL-1901
Open

feat: add httproute for git server#3293
merll wants to merge 6 commits into
mainfrom
APL-1901

Conversation

@merll
Copy link
Copy Markdown
Collaborator

@merll merll commented May 29, 2026

📌 Summary

This PR adds a HTTPRoute for the lightweight Git server.

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@merll merll requested review from Ani1357 and j-zimnowoda as code owners May 29, 2026 10:45
@svcAPLBot
Copy link
Copy Markdown
Contributor

Comparison of Helm chart templating output:

# New file added: git-server/templates/httproute.yaml
# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml

# values-repo.yaml

Copy link
Copy Markdown
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have renamed enableRoute => createHttpRoute

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Exposes the in-cluster git-server via a Gateway API HTTPRoute at git.<domainSuffix>, attached to the shared platform HTTPS Gateway listener. Follows the same pattern used by Argo CD / Keycloak (chart-native HTTPRoute + Otomi values wiring via the shared routes.gotmpl snippet).

Changes:

  • Adds a new templates/httproute.yaml and httproute.* defaults to the git-server chart.
  • Wires the route in values/git-server/git-server.gotmpl using shared parentRefs/annotations from helmfile.d/snippets/routes.gotmpl, gated by apps.git-server.createHttpRoute.
  • Adds createHttpRoute to values-schema.yaml and defaults it to true in helmfile.d/snippets/defaults.yaml.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
charts/git-server/templates/httproute.yaml New chart-native HTTPRoute template with optional labels/annotations/additionalRules.
charts/git-server/values.yaml Adds disabled-by-default httproute value block.
values/git-server/git-server.gotmpl Wires the HTTPRoute when createHttpRoute is true, using the shared route snippet and git.<domainSuffix> hostname.
helmfile.d/snippets/defaults.yaml Defaults apps.git-server.createHttpRoute: true.
values-schema.yaml Adds createHttpRoute boolean to the apps.git-server schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants