feat: optimize helm chart values for the argocd sync

[j-zimnowoda]

📌 Summary

• Yaml diff is sensitive to list order, thus sortAlpha
• the --server-side argument ensures that Application does not have kubectl.kubernetes.io/last-applied-configuration which is lengthy and unnecessary
• the revisionHistoryLimit set to 2 instead of 1=default 10, which aims limiting the size of argocd application status.history object
• the sortTeamConfigArraysByName ensures that arrays of objects are sorted, so values for team-ns helm chart does not trigger faked argocd sync operation

🔍 Reviewer Notes

Some useful scripts to debug

kubectl get events -n argocd --field-selector involvedObject.kind=Application  --sort-by=.metadata.creationTimestamp | grep '> OutOfSync'

appName="team-alpha-team-ns-alpha"
kubectl get applications.argoproj.io  $appName -n argocd -o jsonpath='{.status.history[-1].source.helm.values}' > /tmp/history-1.yaml
kubectl get applications.argoproj.io  $appName -n argocd -o jsonpath='{.status.history[-2].source.helm.values}' >  /tmp/history-2.yaml
dyff between /tmp/history-1.yaml /tmp/history-2.yaml

🧹 Checklist

• Code is readable, maintainable, and robust.
• Unit tests added/updated

[CasLubbers]

Tested on cluster. Seeing only 2 history limit and now sorting issues found with team resources