fix(policy-test): correct panic message typos in http{1,2}_routes#15316
Open
unleashed wants to merge 1 commit into
Open
fix(policy-test): correct panic message typos in http{1,2}_routes#15316unleashed wants to merge 1 commit into
unleashed wants to merge 1 commit into
Conversation
Both helpers incorrectly read "proxy protocol must be Grpc" when they actually expect Http1 and Http2. Signed-off-by: Alejandro Martinez Ruiz <amr@buoyant.io>
cratelyn
approved these changes
May 26, 2026
adleong
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix copy-paste typos in the
http1_routesandhttp2_routestest helpersin
policy-test/src/outbound_api.rs. Both panic messages incorrectly read"proxy protocol must be Grpc" instead of "Http1" and "Http2".
Since these functions use
#[track_caller], the panic message distinguisheswhich protocol assertion failed, and the incorrect text could mislead
debugging.