[NPU A3] Fix benchmark issues for fused_linear_jsd and dyt.#1231
Open
sunyi0505 wants to merge 1 commit into
Open
[NPU A3] Fix benchmark issues for fused_linear_jsd and dyt.#1231sunyi0505 wants to merge 1 commit into
sunyi0505 wants to merge 1 commit into
Conversation
Contributor
Author
|
@Tcc0403 This PR is ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix benchmark issues for fused_linear_jsd and dyt.
1.dyt throws errors when using torch.compile on NPU. Add logic in benchmark to disable torch.compile baseline for NPU devices.
2.fused_linear_jsd encounters out-of-limit grid error exceeding 65536 on NPU. The issue arises from taking num_row as grid size. Replace it with min(num_cores, n_rows) to fix the problem.
Testing Done
dyt:

fused_linear_jsd:

Atlas 800T-A3 x86
Complete the following tasks before sending your PR, and replace
[ ]with[x]to indicate you have done them.-->
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence