Prevent FLCE backward when reduction="none"#1126
Draft
nick-knight wants to merge 1 commit intolinkedin:mainfrom
Draft
Prevent FLCE backward when reduction="none"#1126nick-knight wants to merge 1 commit intolinkedin:mainfrom
reduction="none"#1126nick-knight wants to merge 1 commit intolinkedin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an assertion to prevent the backward pass of FLCE (fused linear cross-entropy loss) from being invoked when
reduction="none". This unsupported functionality was previously discussed in #968. This PR also trims some out-of-date text from an existing comment about this functionality gap, and relocates the rest of the comment from the forward pass to the site of the assertion.Testing Done
I was unable to test this PR according to the contributor guidelines. I saw numerous failures with
make testandmake test-convergence, and didn't try to debug them. Thus I am leaving this as a Draft PR.make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence