Qwen3.5moe#1115
Closed
vvvdwbvvv wants to merge 14 commits intolinkedin:mainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
I think for qwen3_5_moe model, mm_token_type_ids param should also be added to lce_forward, as already done for other VL models:
See code in transformers:
CC: @kashif
| output_attentions: Optional[bool] = None, | ||
| output_hidden_states: Optional[bool] = None, | ||
| output_router_logits: Optional[bool] = None, | ||
| cache_position: Optional[torch.LongTensor] = None, |
Contributor
There was a problem hiding this comment.
Suggested change
| mm_token_type_ids: Optional[torch.IntTensor] = None, | |
| cache_position: Optional[torch.LongTensor] = None, |
| output_attentions=output_attentions, | ||
| output_hidden_states=output_hidden_states, | ||
| output_router_logits=output_router_logits, | ||
| cache_position=cache_position, |
Contributor
There was a problem hiding this comment.
Suggested change
| mm_token_type_ids=mm_token_type_ids, | |
| cache_position=cache_position, |
Contributor
Author
|
@albertvillanova Thank you for reviewing, I'll fix that. |
Contributor
Author
|
closed for it is done at #1109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding Qwen3.5_MOE model support
https://huggingface.co/docs/transformers/en/model_doc/qwen3_5_moe
Related issue: #1110
Note
There's undeterministic problem on all qwen's moe model series, not sure what it is. Maybe we should re-examine all the MoE model to check the convergence test
error log:
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence